Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Tutor 17 / Open edX Quince #7

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

mrtmm
Copy link

@mrtmm mrtmm commented Jan 11, 2024

  • Update the install_requires list to support Tutor 17.
  • Update the compatibility matrix in the README accordingly.

@mrtmm mrtmm requested a review from fghaas January 11, 2024 13:20
Copy link
Contributor

@fghaas fghaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please swap the order of commits around in this one, so that each commit in the branch results in a clean CI run.

Maari Tamm added 2 commits January 11, 2024 15:29
Until Tutor 17, just enabling a plugin with "tutor plugin enable"
would not recreate the configuration, meaning the
tests/tutor-sandbox/env directory would remain empty.

As of overhangio/tutor#957, however,
"tutor plugin enable" does automatically also run "tutor config save",
generating a full Tutor configuration.

This means that unless configured otherwise, with Tutor 17 our flake8
checks would test code generated by Tutor, rather than just that
generated by our plugin.

Thus, to make our tests not break once we bump our dependencies to
support Tutor 17, exclude the tests/tutor-sandbox/env checks from
flake8.
* Update the install_requires list to support Tutor 17.
* Update the compatibility matrix in the README accordingly.
@mrtmm mrtmm merged commit eeaa9d7 into hastexo:main Jan 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants